I am wondering if this chart showing the types of attacks in 5e-dnd and what things they can count towards is correct:
The chart works by listing on the y-axis different ways of making an attack and then along the x-axis it lists different phrases features throughout the books use. If something on the y-axis satisfies that condition on the x-axis their box is green, if not, the box is red. Several have descriptions explaining their content as I felt it might be necessary/helpful. The two Yellow boxes are yellow because the answer is conditional (not simply yes or no).
I have chosen to avoid talking about spells in this chart mostly because they would take up quite a few columns/rows, and also because they do not seem to cause people nearly as much confusion as the other types of attacks.
For the purposes of this I would like three things to be assumed. This is so I can know if the main part of the chart is correct and not the sections that have been put up to debate previously on this Stack:
That using a weapon to make an improvised attack removes all of its properties including melee/ranged. Thus throwing a bow at somebody would not be considered an attack with a ranged weapon, because the bow has lost that property, similarly throwing a mace at somebody would not be considered an attack with a melee weapon.
From the same question as above, that improvised attacks transform whatever is being used to make them into weapons for the purpose of that attack. Thus using a table-leg or shield in an improvised attack would momentarily make each of them count as a weapon.
That you cannot use a weapon for a shove or grapple so they do not qualify as attacks with weapons. (A question where the answer was iffy)
1 - Note that the source may change after this posting as it is a Google Doc. For the sake of this question, use the image I have embedded here.