Are there rules on when to use elf (as an adjective) versus elvish versus elven in D&D?
For example, would any of the following sentences be more or less correct than the others?
"Many of them worship the elf gods; the Seldarine."
"Many of them worship the elvish gods; the Seldarine."
"Many of them worship the elven gods; the Seldarine."
Does it vary by edition or setting?
Are there rules on when to use elf (as an adjective) versus elvish versus elven in D&D?
In D&D 5e, at least, there actually are!
The official D&D Style Guide can be found as part of this style guide resource pack on DMsGuild. The latest version is v1.08a, though an older version (v1.04a) of the PDF can be found online here.
On p. 9 of the latest version (or p. 7 of the v1.04a PDF), it provides a word list, with parentheticals occasionally describing what the word refers to or how it is to be used. Of note, these two entries appear:
elven (adjective)
Elvish (language)
An earlier section also notes that language names are always to be capitalized.
In particular, this word list makes it clear: The term "Elvish" should be used to refer to the language, and "elven" should be used as an adjective to refer to anything of or relating to elves. The word "elf" is a noun, not an adjective (though it occasionally appears as part of a compound noun).
(The same distinction exists for dwarves; "Dwarvish" is the language, "dwarven" is the adjective.)
Examples of the usage of both terms can be found in 5e's descriptions of the elf race. For instance:
Your elf character has a variety of natural abilities, the result of thousands of years of elven refinement.
Although elves reach physical maturity at about the same age as humans, the elven understanding of adulthood goes beyond physical growth to encompass worldly experience.
And:
In addition, every elf bears a family name, typically a combination of other Elvish words. Some elves traveling among humans translate their family names into Common, but others retain the Elvish version.
The Languages trait even uses both:
You can speak, read, and write Common and Elvish. Elvish is fluid, with subtle intonations and intricate grammar. Elven literature is rich and varied, and their songs and poems are famous among other races. Many bards learn their language so they can add Elvish ballads to their repertoires.
Here, it describes the Elvish language and ballads in the language, but speaks of the literature of elves in general.
I don't know whether previous editions perfectly follow this same convention, but I imagine that they largely do adhere to similar conventions in this regard.
There are distinct differences in those three sentences.
The term "elf gods" is what's sometimes called a collective noun, where two or more words make up the idea (much like how Best Buy is a noun). You are referring to "elf gods" as a thing.
The term "elvish" is generally used to denote things that are "elf-like", either in appearance or some other way. Elvish is also the language of the elves.
The term "elven" is generally used to described something belonging to or created by the elves.
An Elven Sword is made by the elves, an elvish sword is a particular style of sword, and an elf sword might be made of an elf, or specialize in slaying them.
Using your examples:
"Many of them worship the elf gods..." (Either gods of the elves or elves that are gods)
"Many of them worship the elvish gods..." (Elf-like, either in appearance or similar to the gods of the elves)
"Many of them worship the elven gods..." (Gods created by, worshipped by or belonging to the elves)
This link here as posted above is very helpful in sorting those out.
