The feats for Crafting both Scrolls and Potions both state
Scribing a scroll takes 2 hours if its base price is 250 gp or less, otherwise scribing a scroll takes 1 day for each 1,000 gp in its base price.
Brewing a potion takes 2 hours if its base price is 250 gp or less, otherwise brewing a potion takes 1 day for each 1,000 gp in its base price
A Valet Familiar gains the Cooperative crafting feat which says.
Benefit: You can assist another character in crafting mundane and magical items. You must both possess the relevant Craft skill or item creation feat, but either one of you can fulfill any other prerequisites for crafting the item. You provide a +2 circumstance bonus on any Craft or Spellcraft checks related to making an item, and your assistance doubles the gp value of items that can be crafted each day.
For context, my group is using the Downtime rules which uses 8 hours of time for each action meaning you could craft 4 potions/scrolls during this time as long as they cost less than 250gold. So the question is by RAW could the crafter craft 8 potions/scrolls instead of just 4? Is this also RAI?
My GM disagreed saying the Familiar doubled the possible gold crafted during one session, but you could still only have the same amount of sessions but if you went over the 250 value it went up to the full 8 hours. IE if you craft a potion under 250gold it still takes 2 hours but if you go over that it takes the full 8. The way I read it you double how much you can craft so either you can craft an item in a single hour, or you can craft up to 500gold worth in 2 hours.